refactor: objectNo 캔버스 조회 api에서 userId 조건 제거

This commit is contained in:
Daseul Kim 2025-02-04 13:14:57 +09:00
parent 8b56201dd6
commit 3931ed9bd1
4 changed files with 20 additions and 27 deletions

View File

@ -24,11 +24,11 @@ public class CanvasStatusController {
return canvasStatusService.selectAllCanvasStatus(userId);
}
@Operation(description = "사용자(userId)와 물건번호(objectNo)에 해당하는 캔버스를 조회 한다.")
@GetMapping("/canvas-statuses/by-object/{objectNo}/{userId}")
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(
@PathVariable String objectNo, @PathVariable String userId) throws QcastException {
return canvasStatusService.selectObjectNoCanvasStatus(objectNo, userId);
@Operation(description = "물건번호(objectNo)에 해당하는 캔버스를 조회 한다.")
@GetMapping("/canvas-statuses/by-object/{objectNo}")
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(@PathVariable String objectNo)
throws QcastException {
return canvasStatusService.selectObjectNoCanvasStatus(objectNo);
}
@Operation(description = "캔버스를 등록 한다.")

View File

@ -17,8 +17,8 @@ public interface CanvasStatusMapper {
// 전체 캔버스 조회 by 사용자(userId)
public List<CanvasStatusResponse> selectAllCanvasStatus(String userId);
// 캔버스 조회 by 물건번호(objectNo) && 사용자(userId)
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(String objectNo, String userId);
// 캔버스 조회 by 물건번호(objectNo)
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(String objectNo);
// 캔버스 조회 by Max(id)
public List<CanvasStatusResponse> getMaxIdCanvasStatus(String objectNo, String userId);

View File

@ -26,16 +26,13 @@ public class CanvasStatusService {
return result;
}
// 사용자(userId) 물건번호(objectNo) 해당하는 캔버스 조회
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(String objectNo, String userId)
// 물건번호(objectNo) 해당하는 캔버스 조회
public List<CanvasStatusResponse> selectObjectNoCanvasStatus(String objectNo)
throws QcastException {
List<CanvasStatusResponse> result = null;
if (objectNo != null
&& !objectNo.trim().isEmpty()
&& userId != null
&& !userId.trim().isEmpty()) {
result = canvasStatusMapper.selectObjectNoCanvasStatus(objectNo, userId);
if (objectNo != null && !objectNo.trim().isEmpty()) {
result = canvasStatusMapper.selectObjectNoCanvasStatus(objectNo);
} else {
throw new QcastException(ErrorCode.INVALID_INPUT_VALUE, "올바르지 않은 입력값입니다.");
}

View File

@ -38,22 +38,18 @@
<select id="selectObjectNoCanvasStatus" parameterType="string"
resultType="com.interplug.qcast.biz.canvasStatus.dto.CanvasStatusResponse">
/* sqlid : com.interplug.qcast.canvasStatus.selectObjectNoCanvasStatus 캔버스 조회 by (물건번호(objectNo)
and 사용자(userId)) */
/* sqlid : com.interplug.qcast.canvasStatus.selectObjectNoCanvasStatus 캔버스 조회 by 물건번호(objectNo) */
SELECT id
, user_id
, object_no
, plan_no
, canvas_status
, regist_datetime
, last_edit_datetime
, bg_image_name
, map_position_address
, user_id
, object_no
, plan_no
, canvas_status
, regist_datetime
, last_edit_datetime
, bg_image_name
, map_position_address
FROM TB_CANVAS_STATUS
WHERE object_no = #{objectNo}
<if test="userId != null and userId != ''">
AND user_id = #{userId}
</if>
</select>
<select id="getMaxIdCanvasStatus" parameterType="string"