From a2a658e19c165efeea9849d38587a55064734b12 Mon Sep 17 00:00:00 2001 From: Daseul Kim Date: Tue, 11 Feb 2025 15:37:02 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20canvas=20popup=20status=20=EC=A1=B0?= =?UTF-8?q?=ED=9A=8C=20api=20=EC=9D=98=20=EC=9D=91=EB=8B=B5=EA=B0=92?= =?UTF-8?q?=EC=9D=B4=20=EC=97=86=EC=9D=84=20=EA=B2=BD=EC=9A=B0=20200,=20?= =?UTF-8?q?=EB=B9=88=EA=B0=9D=EC=B2=B4=20=EB=B0=98=ED=99=98=ED=95=98?= =?UTF-8?q?=EB=8F=84=EB=A1=9D=20=EC=88=98=EC=A0=95?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../canvaspopupstatus/CanvasPopupStatusController.java | 3 +-- .../biz/canvaspopupstatus/CanvasPopupStatusService.java | 8 ++------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusController.java b/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusController.java index 3cdcdef4..086bd070 100644 --- a/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusController.java +++ b/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusController.java @@ -31,8 +31,7 @@ public class CanvasPopupStatusController { * @param objectNo 물건정보 번호 * @param planNo plan 번호 * @param popupType 캔버스 팝업 단계 - * @return 조회된 CanvasPopupStatus 객체 - * @throws QcastException 조회된 데이터가 없을 경우 예외 발생 + * @return 조회된 CanvasPopupStatus 객체, 조회된 데이터가 없을 경우 빈 객체 반환 */ @Operation(description = "캔버스 팝업 상태를 조회한다.") @GetMapping diff --git a/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusService.java b/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusService.java index aaffa1b1..2b0e86d4 100644 --- a/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusService.java +++ b/src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusService.java @@ -18,16 +18,14 @@ public class CanvasPopupStatusService { * @param objectNo 조회할 object 번호 * @param planNo 조회할 plan 번호 * @param popupType 조회할 popup 타입 - * @return 조회된 CanvasPopupStatus 객체 - * @throws QcastException 조회된 데이터가 없을 경우 예외 발생 + * @return 조회된 CanvasPopupStatus 객체, 조회된 데이터가 없을 경우 빈 객체 반환 */ public CanvasPopupStatus selectCanvasPopupStatus( String objectNo, Integer planNo, String popupType) throws QcastException { CanvasPopupStatus request = CanvasPopupStatus.builder().objectNo(objectNo).planNo(planNo).popupType(popupType).build(); CanvasPopupStatus cps = canvasPopupStatusMapper.selectCanvasPopupStatus(request); - if (cps == null) throw new QcastException(ErrorCode.NOT_FOUND); - return cps; + return cps != null ? cps : CanvasPopupStatus.builder().build(); } /** @@ -80,8 +78,6 @@ public class CanvasPopupStatusService { * @throws QcastException 삭제 중 예외 발생 시 */ public void deleteCanvasPopupStatus(CanvasPopupStatus cps) throws QcastException { - // 존재 유무 확인 - selectCanvasPopupStatus(cps.getObjectNo(), cps.getPlanNo(), cps.getPopupType()); try { canvasPopupStatusMapper.deleteCanvasPopupStatus(cps); } catch (Exception e) {