qcast3/qcast-api
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: canvas popup status 조회 api 의 응답값이 없을 경우 200, 빈객체 반환하도록 수정

Browse Source
This commit is contained in:
Daseul Kim 2025-02-11 15:37:02 +09:00
parent c21c61a32d
commit a2a658e19c
2 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusController.java
View File

@ -31,8 +31,7 @@ public class CanvasPopupStatusController {
* @param objectNo 물건정보 번호 * @param objectNo 물건정보 번호
* @param planNo plan 번호 * @param planNo plan 번호
* @param popupType 캔버스 팝업 단계 * @param popupType 캔버스 팝업 단계
* @return 조회된 CanvasPopupStatus 객체 * @return 조회된 CanvasPopupStatus 객체, 조회된 데이터가 없을 경우 빈 객체 반환
* @throws QcastException 조회된 데이터가 없을 경우 예외 발생
*/ */
@Operation(description = "캔버스 팝업 상태를 조회한다.") @Operation(description = "캔버스 팝업 상태를 조회한다.")
@GetMapping @GetMapping

8
src/main/java/com/interplug/qcast/biz/canvaspopupstatus/CanvasPopupStatusService.java
View File

@ -18,16 +18,14 @@ public class CanvasPopupStatusService {
* @param objectNo 조회할 object 번호 * @param objectNo 조회할 object 번호
* @param planNo 조회할 plan 번호 * @param planNo 조회할 plan 번호
* @param popupType 조회할 popup 타입 * @param popupType 조회할 popup 타입
* @return 조회된 CanvasPopupStatus 객체 * @return 조회된 CanvasPopupStatus 객체, 조회된 데이터가 없을 경우 빈 객체 반환
* @throws QcastException 조회된 데이터가 없을 경우 예외 발생
*/ */
public CanvasPopupStatus selectCanvasPopupStatus( public CanvasPopupStatus selectCanvasPopupStatus(
String objectNo, Integer planNo, String popupType) throws QcastException { String objectNo, Integer planNo, String popupType) throws QcastException {
CanvasPopupStatus request = CanvasPopupStatus request =
CanvasPopupStatus.builder().objectNo(objectNo).planNo(planNo).popupType(popupType).build(); CanvasPopupStatus.builder().objectNo(objectNo).planNo(planNo).popupType(popupType).build();
CanvasPopupStatus cps = canvasPopupStatusMapper.selectCanvasPopupStatus(request); CanvasPopupStatus cps = canvasPopupStatusMapper.selectCanvasPopupStatus(request);
if (cps == null) throw new QcastException(ErrorCode.NOT_FOUND); return cps != null ? cps : CanvasPopupStatus.builder().build();
return cps;
} }
/** /**
@ -80,8 +78,6 @@ public class CanvasPopupStatusService {
* @throws QcastException 삭제 중 예외 발생 시 * @throws QcastException 삭제 중 예외 발생 시
*/ */
public void deleteCanvasPopupStatus(CanvasPopupStatus cps) throws QcastException { public void deleteCanvasPopupStatus(CanvasPopupStatus cps) throws QcastException {
// 존재 유무 확인
selectCanvasPopupStatus(cps.getObjectNo(), cps.getPlanNo(), cps.getPopupType());
try { try {
canvasPopupStatusMapper.deleteCanvasPopupStatus(cps); canvasPopupStatusMapper.deleteCanvasPopupStatus(cps);
} catch (Exception e) { } catch (Exception e) {